Like many careers, if you take the long view it is still a good career if flying is really your vocation. Many professions have taken a hit in terms of lifestyle and remuneration and many have barriers to entry higher than aviation. In financial terms, you will eventually be well paid by most standards. Loans for licences will be paid down in much the same way and rate as a student loan.
What would put me off with the benefit of 25 years hindsight, is the shift work. I'd avoid any job where I had to work nights or weekends.