I used to be in the "landing lights on in the circuit" camp but now only use them in hazy conditions or at night. In Canada you are not required to even have a functioning landing at night unless you are carrying a pax.
Anti colision and nav lights are required though.