Thats odd my instructer used the poor weather days for circuits as it was good practice and the vis was too crap to go outside the circuit.
No, it's not odd. You can do circuits when the VISIBILITY isn't good enough for upper air work and navigation. But if the wind is too strong or in the wrong direction, that's not good, at least in the beginning. No, the weather doesn't have to be perfect for circuits, but it can sometimes feel like it to the student, if you've hit a patch of windy, gusty days with heavy showers.
He's a great guy, but he does it for the money
We all do it for the money, up to a point; all instructors have to eat. But the student's needs should come first. If an instructor prefers two-hour slots because he makes more money that way, not because it's best for the student, then he shouldn't be doing that job. And if you do have an instructor like that, I don't care how great a guy he is - get a new instructor. You can always go out for a drink with the "great guy", but don't fly with him. I wasted a lot of money in the early days flying with a really great guy, until I finally learned enough to decide to change instructors.