No one can really predict a certain future; who expected the pandemic in 2019? The instructor has a valid point but it's an opinion after all. It's a personal choice if you decide to go for an aviation career or not, but remember that many other careers are expected to decrease in the future and people are still going for them. It is a personal decision.
Good luck!