There will never be a shortage of flying instructors.
There will always more instructors than jobs available.
I,m always amazed that people moan about the poor money instructors receive after 'they' have had the benefit of cheap instructors on their way up the ladder.
My advice in the past to anybody wanting to be an instructor unless you can get into a very busy school, keep it part time, say weekends and get a good paid job during the week.
If you are at a busy school you haven't got time to worry how bad the pay is. Just keep busting your**** to keep your students happy. They will come back for more and you be the richer in more than monetary terms.
Remember flying instructing is one of the few jobs where you are surrounded by people who want to be there. After 14 years as a flying instructor/CFI/Examiner i'm taking time out and now in a job outside aviation and surrounded by people with long faces all day.