Plenty of very good accounts on this thread and it only goes to show that there are as big a range of flying instructors as there are people in any other walk of life.
Personally, I got on with all my instructors, regardless of their quirks. Some of them are even here and I thank them. I agree that some fellow studes felt a bit dubious about the more "boisterous" instructors, especially in the early days, but most made it through to a high standard. So make of that what you will.