Re the RAF uniform, according to Wikipedia he learnt to fly in 1937 in Edinburgh with the university Air Unit and I assumed the photo was from that era. It also says that on his return from Germany he joined the RNVR as a FAA pilot. I can't find my copy of Wings on My Sleeve to check