One would hope that somebody with a significant instructional background has both significant flying ability, and an excellent understanding of the need to work to rules and procedures.
Whilst my airline experience is very limited, my significant test flying experience is that ex-instructors generally make very good Test Pilots, because of their combined good communication and teamwork skills, and ability to observe and analyse what's going on.