I've used this analogy for decades without difficulty, students normally find that it helps when doing basic cell theory, Nernst, E cell v E Standard etc.
But, as explained above and like many analogies, it has its limitations.
Physicists get uneasy when using it as students then start to follow electron flow in circuits rather than conventional current. Chemists just smile!
CW