Learning is defined as a desired change of behaviour. And if that is being achieved, and both instructor and student are clear on what desired behaviour and standard they are aiming for, then however you achieve these aims is up to your own style, matched with the students personality, and as the years go by you learn more and more new techniques that work for different people. For a student to prgress they need reassurance that you are on their side.
In the early stages as an instructor, think of the instructor in your past who you learned the most from and ask yourself what made them so good, then you have a role model. Then think of the worst one, and ensure that you learn from their mistakes. A yelling instructor is often one who is blaming their own incompetence on the student, and should go and find another job.
Sometimes there are students who are difficult to like and/or incredibly frustrating, but that is something you learn to take in your stride. Occasionally there will be a student who you just can't get along with-do everyone a favour and find them another instructor sooner rather than later, don't see it as a failure.
Here's a few traits I've seen from new instructors (including me many moons ago) which improve with experience:
1 Over instructing...talking too much because you are worried about missing something out!
2 Running late, often because you get into an interesting conversation before the flight, or find yourself at the far end of the training area when the aircraft has it's next booking ten minutes ago....
3 Talking too much and bewildering the poor stude with information they don't need yet. My favourite instructor hardly said anything, but when he did I knew it was important and really listened. Or maybe he was asleep.
Here's some tips I wish someone had given me when I started instructing:
1 The only words you should ever say on the runway are "I have control" if they have blown it, wait until you are established on upwind before talking about the last touch and go, and keep the controls until you have finished talking. Two sentences should be enough.
2 Never forget what you went through when you were at their stage of training.
3 Avoid eating garlic and never smoke in working hours! ( the one time I went gliding my instructor had garlic breath and it put me off for life)
4 Learn the art of "Here's your headset, I'll be out in ten minutes"

and enjoying your coffee without then going out to find a cobwebby skeleton waiting for you! My pet hate as a student was being able to see my instructor through the window have a game of pool (or once, a double scotch at the bar) while you have been out there for half an hour, then the lesson is cut short 'cos you are "running late"
Sorry to rattle on so much. I've never been able to cure myself of talking too much!
Good luck Whirly!

Given the enthusiasm and passion for flying you have shown in your posts, I think you will be a great instructor. Given what I have put my helicopter instructor through in terms of totally inappropriate cylclic inputs you will need quick reactions!!