As an ex-RAF controller, now NATS, I would say it depends on the individuals concerned. You will get a fuller picture by visiting an RAF unit; personally, I had some great times (at home and overseas) and wouldn't change if I had my time again. If you choose the RAF you must be prepared to move. He will go away for 4 or 6 month detachments every 5 or 6 years on average, but you will also get the chance to move around (Cyprus, Scotland etc) when he is posted - if this doesn't suit, I wouldn't recommend it. These days you get a fair say where you want to go, but places overseas are not what they used to be. It's good fun when you are young but get out into civil later on if you can. A lot of my peers did exactly that and a significant number of civil (NATS and other providers) controllers are ex-RAF. Visit them both and you choose! He will still have to pass some rigorous selection testing whatever he chooses and be medically fit.
Hope this helps.
