Given my time again I would not have become an instructor and would have put the money I spent on my FI ticket towards a rating.
We are all in different positions but I never regret doing my FI rating. I learned a lot from it and did some good flying. It also enabled me to climb the ladder fairly quickly at my last airline since once I moved to the LHS, I was made up to a trainer pretty quickly due to my FI background. Teaching people for a PPL is more useful than you think!