I think pro diving and flying are quite similar in many ways. Except with flying you are more likely to one day (maybe) get a job where you are home almost every night
.
With regards to instructing, I still think it is a good step after the PPL. You have the advantage of another string to your bow in that, to a certain degree you can subsidise your instructor's wage with occasional trips offshore.
But it can be a slog to the airlines...but I guess you are use to that. (And use to sharing confined pressurised spaces with other people).