Hi Will,
Hope the renovating is going well, I know it can be a nightmare. But, as you say, the increase in revenue is a nice return
In regards to your own situation, just be careful at taking statements like "instructors job on completion" etc as gospel. Unless you have this as a formal job offer before you start your training (of which there is ZERO possibility, I would imagine), you're definitely not guaranteed an instructor's job.
Is the aviation degree arranged through the flight school or do you have to sort all that yourself? Will this involve a substantial extra investment? Blah blah...ask yourself all the obvious questions and ensure you're fully comfortable with the answers.
If in doubt, keep looking.
Personally, I know nothing about the school so please just take this as my opinion and advice. The degree sounds very good if it's arranged through the flight school, and yes, most (ALL of the major US airlines) require you to have a four-year university degree.
The two basic rules are:
1. Never pay all training costs up front
2. Always have a back-up plan
Simple.
Regards,
Simon.