Yep - I am pretty much in agreance with FlyingTuur, whatunion, etc.
The visual approach is a skill that needs working on. As has already been pointed out - it is the most basic of flying skills, and I believe everybody should be able to fly their aircraft from A to B without having to rely on ATC to hold their hands.
There are still many places in the world where the demanding skill of the circling (visual) approach is still required, and it is therefore a very necessary tool to have in your toolbag. I cannot comprehend how on earth anybody can possibly expect to carry one out safely if they can't even position and configure their aircraft for a basic straight-in visual in benign conditions.
I too encourage the practice of a visual approach from my effohs - they are fooling themselves if they think they can live their professional lives without gaining this skill.
A big part of it is judging when more track miles are required, and then requesting it from ATC if necessary.