I've flown with both types, both during initial training and since in a professional capacity
Civilian - Lots of types/personalities. Instructional standards a bit variable, but where else could you learn crop spraying techniques with only 10 hrs! (Thanks Barry!) Most 'self-improvers' I have flown with have been sound personalities.
Military - Spent a lot of time being told how wonderful they were ("When I was a Lightning/Phantom/Hawk/Buccaneer pilot.........zzzzzzzzzzzzzzzzzzzzzzzzzzz"). Standards typically good, but then so would the civvie instructor's be if they were having money thrown at them! (Thanks Liz). Absolutely NO engine handling skills whatsoever, esp with vintage engines ("But it says that in the AP"). An inability to conform to everyday civilian rules and regs..("We never did it like that in the RAF")
My view is that the RAF way is not always the way to do it in the civvie world, in civvie aircraft. However, they seem to have superior instructional standards.
This subject will roll on forever, depending on who you talk to.