".the strategy failure of the Tet Offensive by the North Vietnamese is the expected popular uprising of the people of South Vietnam did not take place."
very true and often forgotten - BUT it convinced the US public that the South was no longer going to win - public support collapsed after Tet so in the medium term it was a gigantic win for the NVA