Been a long haul pilot for 16 years. Never done anything else so I can't comment on other jobs. I have loved it and would not change it. People here are not wrong when they say it be a challenge and lay-offs can happen - I imagine the same as any profession. If your children have no resilience or ability to handle rough times then they probably would not make a good pilot anyway.
I say if that is what he wants to do then go for it. Pilots will still have a long career and pilotless planes are still very far off.