Just to chip in, I wear what I feel comfortable in when flying along with thin leather gloves. The only reason for the gloves is that my hands sweat (not dramatically, but enough) and I see who else flies the aeroplane other than me.
For aeros I wear a nomex suit and own three to date. Two RAF Mk16 and one other made-to-measure number. The only badge I have that I transfer between the suits as required is my name badge, which does include wings because I can
. Wouldn't wear one for PA28/C172 flying though, as I feel the worst thing that could happen is an engine failure at which point I'm flying a glider, no great shakes.
Call me naive or over trusting of the aircraft and/or maintenance engineers if you wish, but if it's going to break up in flight a flying suit will only keep all my bits in a nice easily transportable bag. And I'm never going to wear a parachute in the typical club hack.
There's ma 2p worth, frankly wear whatever is comfortable be it a 1990s shell suit or a nomex suit with bells and whistles.